michaeljmarshall commented on a change in pull request #13123:
URL: https://github.com/apache/pulsar/pull/13123#discussion_r762381767
##########
File path:
pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/runtime/thread/ThreadRuntime.java
##########
@@ -149,7 +149,7 @@ private static ClassLoader loadJars(String jarFile,
} catch (FileNotFoundException e) {
// this is usually like
// java.io.FileNotFoundException:
/tmp/pulsar-nar/xxx.jar-unpacked/xxxxx/META-INF/MANIFEST.MF'
- log.error("The file {} does not look like a .nar file",
jarFile, e.toString());
+ log.error("The file {} does not look like a .nar file {}",
jarFile, e.toString());
Review comment:
@eolivelli - was your intention in
https://github.com/apache/pulsar/pull/12667 to avoid logging the error's stack
trace? If not, we could also drop the `.toString()` to make this log line work.
```suggestion
log.error("The file {} does not look like a .nar file",
jarFile, e);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
