lhotari commented on a change in pull request #13134: URL: https://github.com/apache/pulsar/pull/13134#discussion_r762422742
########## File path: managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerFactoryImpl.java ########## @@ -352,6 +352,7 @@ public void asyncOpen(final String name, final ManagedLedgerConfig config, final // Managed ledger is in unusable state. Recreate it. log.warn("[{}] Attempted to open ledger in {} state. Removing from the map to recreate it", name, l.getState()); + l.close(); Review comment: Should it be called asynchronously after the removal from the map? What if close blocks or throws an exception? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org