codelipenghui commented on a change in pull request #12517:
URL: https://github.com/apache/pulsar/pull/12517#discussion_r764981011
##########
File path:
pulsar-common/src/main/java/org/apache/pulsar/common/events/PulsarEvent.java
##########
@@ -35,4 +37,9 @@
private EventType eventType;
private ActionType actionType;
private TopicPoliciesEvent topicPoliciesEvent;
+ /**
+ * Which remote clusters to replicate to
+ */
+ private List<String> replicateTo;
Review comment:
And I think we can avoid adding `replicateTo` in PulsarEvent? instead,
we can introduce `isGlobal` in TopicPoliciesEvent? TopicPolicies already have
`isGlobal` information, so that we can use it directly in the
`TopicPoliciesSystemTopicClient.java`, it looks like
```
if (event.policies.isGlobal) {
.replicationClusters(null);
} else {
.replicationClusters(emptySet);
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
