Jason918 commented on a change in pull request #13208:
URL: https://github.com/apache/pulsar/pull/13208#discussion_r766314855
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/impl/OverloadShedder.java
##########
@@ -103,8 +104,10 @@
// make up for at least the minimum throughput to offload
loadData.getBundleData().entrySet().stream()
- .filter(e ->
!HEARTBEAT_NAMESPACE_PATTERN.matcher(e.getKey()).matches()
- &&
!HEARTBEAT_NAMESPACE_PATTERN_V2.matcher(e.getKey()).matches()
+ .filter(e -> !HEARTBEAT_NAMESPACE_PATTERN.matcher(
Review comment:
This filter will be used in all `LoadSheddingStrategy`, I think we can
add a method like `getBundleDataForLoadShedding` in LoadData.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
