eolivelli commented on a change in pull request #13280:
URL: https://github.com/apache/pulsar/pull/13280#discussion_r768433682



##########
File path: 
pulsar-client/src/main/java/org/apache/pulsar/client/impl/MessageImpl.java
##########
@@ -76,6 +76,7 @@
     private BrokerEntryMetadata brokerEntryMetadata;
 
     private boolean poolMessage;
+    private boolean dlqMessage;

Review comment:
       I wonder if it is possible to not add this new field to MessageImpl.
   A new field has a runtime weight.
   
   if the problem is only about not "releasing" the message if it is send to 
the DLQ, what about simply "retaining" one more time before adding it to the 
`possibleSendToDeadLetterTopicMessages` list ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to