merlimat commented on a change in pull request #13344:
URL: https://github.com/apache/pulsar/pull/13344#discussion_r769799183
##########
File path:
pulsar-client-api/src/main/java/org/apache/pulsar/client/api/ProducerBuilder.java
##########
@@ -172,7 +172,7 @@
* the client application. Until, the producer gets a successful
acknowledgment back from the broker,
* it will keep in memory (direct memory pool) all the messages in the
pending queue.
*
- * <p>Default is 1000.
+ * <p>Default is 0, disable the pending messages check.
Review comment:
We should also deprecate `maxPendingMessagesAcrossPartitions()` (and
setting it to 0 by default), because memory limit is a better approach to limit
the max amount of memory.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
