nicoloboschi commented on a change in pull request #13057:
URL: https://github.com/apache/pulsar/pull/13057#discussion_r770370849
##########
File path:
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ProducerImpl.java
##########
@@ -1292,6 +1293,12 @@ protected OpSendMsg newObject(Handle<OpSendMsg> handle) {
};
}
+ private static double nsToSeconds(long ns) {
Review comment:
There's always a starting point and perhaps there were other times when
this argument has been exposed and now we haven't created the `TimeUtils` class
yet
More in general, duplicating code is a serious problem and can be lead to a
security problems. A utility class with single method is always better to a
duplicate method
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
