315157973 commented on a change in pull request #13297:
URL: https://github.com/apache/pulsar/pull/13297#discussion_r771133205
##########
File path:
pulsar-broker/src/test/java/org/apache/pulsar/schema/compatibility/SchemaTypeCompatibilityCheckTest.java
##########
@@ -185,6 +204,7 @@ public void structTypeProducerConsumerUndefinedCompatible()
throws Exception {
@Test
public void structTypeConsumerProducerUndefinedCompatible() throws
Exception {
admin.namespaces().setSchemaCompatibilityStrategy(namespaceName,
SchemaCompatibilityStrategy.UNDEFINED);
+ setTopicLevelPoliciesEnabled(false);
Review comment:
It seems that every unit test needs to be set up like this, why not move
it to `setup()`?
##########
File path:
pulsar-broker/src/test/java/org/apache/pulsar/schema/compatibility/SchemaTypeCompatibilityCheckTest.java
##########
@@ -101,9 +117,44 @@ public void testSchemaCompatibilityStrategyInBrokerLevel()
throws PulsarClientEx
assertTrue(t.getMessage().contains("org.apache.avro.SchemaValidationException:
Unable to read schema"));
}
+ @Test
+ public void testSchemaCompatibilityStrategyInTopicLevel()
Review comment:
Please add a unit test to test the priority between different levels of
strategies
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
