eolivelli commented on a change in pull request #12700:
URL: https://github.com/apache/pulsar/pull/12700#discussion_r771198476
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/transaction/pendingack/impl/MLPendingAckStore.java
##########
@@ -303,13 +302,12 @@ public void addFailed(ManagedLedgerException exception,
Object ctx) {
@Override
public void run() {
try {
- while (lastConfirmedEntry.compareTo(currentLoadPosition) > 0) {
- if (((ManagedCursorImpl) cursor).isClosed()) {
- log.warn("[{}] MLPendingAckStore cursor have been
closed, close replay thread.",
- cursor.getManagedLedger().getName());
- return;
- }
- fillEntryQueueCallback.fillQueue();
+ if (cursor.isClosed()) {
Review comment:
why did you move this outside of the _while_ loop ?
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/transaction/pendingack/impl/MLPendingAckStore.java
##########
@@ -389,6 +389,11 @@ public Entry get() {
@Override
public void readEntriesFailed(ManagedLedgerException exception, Object
ctx) {
+ if (managedLedger.getConfig().isAutoSkipNonRecoverableData()
+ && exception instanceof
ManagedLedgerException.NonRecoverableLedgerException
+ || exception instanceof
ManagedLedgerException.ManagedLedgerFencedException) {
+ isReadable = false;
+ }
log.error("MLPendingAckStore stat reply fail!", exception);
Review comment:
is it possible to add the name of the topic ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
