lhotari commented on a change in pull request #13381:
URL: https://github.com/apache/pulsar/pull/13381#discussion_r771422679
##########
File path: conf/pulsar_tools_env.sh
##########
@@ -48,7 +48,7 @@ PULSAR_MEM="-Xmx128m -XX:MaxDirectMemorySize=128m"
PULSAR_GC=" -client "
# Extra options to be passed to the jvm
-PULSAR_EXTRA_OPTS="${PULSAR_EXTRA_OPTS} ${PULSAR_MEM} ${PULSAR_GC}
${PULSAR_GC_LOG} -Dio.netty.leakDetectionLevel=disabled"
+PULSAR_EXTRA_OPTS="${PULSAR_MEM} ${PULSAR_EXTRA_OPTS} ${PULSAR_GC}
${PULSAR_GC_LOG} -Dio.netty.leakDetectionLevel=disabled"
Review comment:
+1. One slight improvement:
Please move `${PULSAR_EXTRA_OPTS}` as the very last entry so that it will
also be possible to override `io.netty.leakDetectionLevel` when needed.
btw. I happened to do a similar change in `bin/pulsar` script recently in
https://github.com/apache/pulsar/pull/13025/files#diff-89618c73d511b2015766c1fb0cd4bd16aa7f949dfdfa02d1995b586b8ed57d7aL283
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
