yuruguo commented on a change in pull request #13395:
URL: https://github.com/apache/pulsar/pull/13395#discussion_r771927714
##########
File path:
pulsar-metadata/src/main/java/org/apache/pulsar/metadata/bookkeeper/PulsarLedgerIdGenerator.java
##########
@@ -95,7 +95,7 @@ public void
generateLedgerId(BookkeeperInternalCallbacks.GenericCallback<Long> g
// delete the znode for id generation
store.delete(stat.getPath(), Optional.empty()).
exceptionally(ex -> {
- log.warn("Exception during deleting node for
id generation : {}", ex);
+ log.warn("Exception during deleting node for
id generation: ", ex);
Review comment:
Is there no need to add `{}` here?
##########
File path:
pulsar-metadata/src/main/java/org/apache/pulsar/metadata/bookkeeper/PulsarLedgerIdGenerator.java
##########
@@ -226,7 +226,7 @@ private String formatHalfId(int i) {
// delete the znode for id generation
store.delete(stat.getPath(), Optional.empty()).
exceptionally(ex -> {
- log.warn("Exception during deleting node for
id generation : {}", ex);
+ log.warn("Exception during deleting node for
id generation: ", ex);
Review comment:
same as above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
