michaeljmarshall commented on a change in pull request #13424:
URL: https://github.com/apache/pulsar/pull/13424#discussion_r774335745
##########
File path:
pulsar-common/src/main/java/org/apache/pulsar/common/util/keystoretls/KeyStoreSSLContext.java
##########
@@ -105,7 +105,11 @@ public KeyStoreSSLContext(Mode mode,
? DEFAULT_KEYSTORE_TYPE
: trustStoreTypeString;
this.trustStorePath = trustStorePath;
- this.trustStorePassword = trustStorePassword;
+ if (trustStorePassword == null) {
+ this.trustStorePassword = "";
+ } else {
+ this.trustStorePassword = trustStorePassword;
+ }
Review comment:
I didn't know about those tests. Thank you for explaining. In that case,
I think we should document the appropriate configuration values to indicate
that `null` is converted to `""`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
