315157973 commented on a change in pull request #13469:
URL: https://github.com/apache/pulsar/pull/13469#discussion_r774431736
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/SystemTopicBasedTopicPoliciesService.java
##########
@@ -263,9 +267,15 @@ private void prepareInitPoliciesCache(NamespaceName
namespace, CompletableFuture
protected CompletableFuture<SystemTopicClient.Reader<PulsarEvent>>
creatSystemTopicClientWithRetry(
NamespaceName namespace) {
+ CompletableFuture<SystemTopicClient.Reader<PulsarEvent>> result = new
CompletableFuture<>();
+ try {
+ createSystemTopicFactoryIfNeeded();
+ } catch (PulsarServerException e) {
+ result.completeExceptionally(e);
+ return result;
+ }
Review comment:
Here fix the NPE, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
