BewareMyPower commented on a change in pull request #12403:
URL: https://github.com/apache/pulsar/pull/12403#discussion_r775151856
##########
File path:
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ProducerImpl.java
##########
@@ -1178,12 +1190,46 @@ protected boolean
verifyLocalBufferIsNotCorrupted(OpSendMsg op) {
}
}
+ static class ChunkedMessageCtx {
Review comment:
Sorry I missed it. You are right. Multiple `OpSendMsg`s share the same
`ChunkedMessageCtx`.
However, I found a more serious problem and it should be a requested change.
I found `ChunkedMessageCtx#recycle()` is never called. You should add some
logic like reference count to call `recycle()` for this method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
