codelipenghui commented on a change in pull request #13533:
URL: https://github.com/apache/pulsar/pull/13533#discussion_r775821748
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/compaction/CompactedTopicImpl.java
##########
@@ -311,9 +310,8 @@ private static int comparePositionAndMessageId(PositionImpl
p, MessageIdData m)
.compare(p.getEntryId(), m.getEntryId()).result();
}
- @VisibleForTesting
- PositionImpl getCompactionHorizon() {
- return this.compactionHorizon;
+ public synchronized Optional<Position> getCompactionHorizon() {
Review comment:
Another thread update the `compactionHorizon`
https://github.com/apache/pulsar/blob/07ef9231db8b844586b9217ee2d59237eb9c54b7/pulsar-broker/src/main/java/org/apache/pulsar/compaction/CompactedTopicImpl.java#L70
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
