codelipenghui commented on a change in pull request #10478:
URL: https://github.com/apache/pulsar/pull/10478#discussion_r776394773
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentSubscription.java
##########
@@ -1114,11 +1114,13 @@ public SubscriptionStatsImpl getStats(Boolean
getPreciseBacklog, boolean subscri
}
@Override
- public void redeliverUnacknowledgedMessages(Consumer consumer) {
+ public CompletableFuture<Void> redeliverUnacknowledgedMessages(Consumer
consumer, long consumerEpoch) {
Dispatcher dispatcher = getDispatcher();
if (dispatcher != null) {
- dispatcher.redeliverUnacknowledgedMessages(consumer);
+ return dispatcher.redeliverUnacknowledgedMessages(consumer,
consumerEpoch);
}
+ return FutureUtil.failedFuture(
Review comment:
should be a behavior change, is it necessary?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
