codelipenghui commented on a change in pull request #13481:
URL: https://github.com/apache/pulsar/pull/13481#discussion_r776568821
##########
File path:
pulsar-broker/src/test/java/org/apache/pulsar/broker/transaction/pendingack/PendingAckPersistentTest.java
##########
@@ -344,4 +346,42 @@ private void
testDeleteTopicThenDeletePendingAckManagedLedger() throws Exception
assertFalse(topics.contains(MLPendingAckStore.getTransactionPendingAckStoreSuffix(topic,
subName2)));
assertFalse(topics.contains(topic));
}
+
+ @Test
+ public void testTxnCumulativeAckInOrder() throws Exception{
Review comment:
Without this PR, the test still can get passed, could you please help
check if this is a correct test for cover the new changes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
