mattisonchao edited a comment on pull request #13573: URL: https://github.com/apache/pulsar/pull/13573#issuecomment-1005402430
> From the PR title, I think the test should cover the case that reset-cursor is operated against a non-existent topic. However, your test just mocks that case that a `RuntimeException` is thrown. > > Could you add a test that `Topics#resetCursor` is called when the topic doesn't exist like what `AdminApiTest` does? According to relate issue : #13551 The original issue is ZK session timeout, we are finding the reason. This PR just solve the ``getTopicReference `` may cause NPE, when exception not throw from completable future. Therefore, I changed the PR title and continued to work on this issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
