equanz commented on a change in pull request #12401:
URL: https://github.com/apache/pulsar/pull/12401#discussion_r749949370
##########
File path: pulsar-common/src/main/proto/PulsarApi.proto
##########
@@ -485,6 +485,8 @@ message CommandProducer {
optional uint64 topic_epoch = 11;
optional bool txn_enabled = 12 [default = false];
+
+ optional bool partial_producer_supported = 13 [default = false];
Review comment:
First, we didn't discuss about the wire protocol change. So, I'll also
send a new mail to [the
thread](https://mail-archives.apache.org/mod_mbox/pulsar-dev/202102.mbox/%[email protected]%3e).
Currently, partitioned producer can't aggregate by any key such as cnx,
producerId, producerName, and so on. I think we need to add any aggregation
system. Therefore, added new aggregation policy as producerName (with client
side implementation).
New protocol field
[partial_producer_supported](https://github.com/apache/pulsar/pull/12401/files#diff-f29399fed32e0916cf28452ba71078a3ae5ed77bbaef9f52a925165d8ee66cfdR489)
is not used for stats aggregation. It is used for backward compatibility.
In my understanding, if introduce new stats aggregation key to client side,
need a way to determine whether the feature is enabled at client side. For
example, whether the producer has specific field or metadata, the version (e.g.
protocol version) is greater than threshold, etc.
Of course, if we can introduce aggregation feature without adding any new
key or implementations from client side, we can support the feature not only
new client but also old one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
