lordcheng10 edited a comment on pull request #13679: URL: https://github.com/apache/pulsar/pull/13679#issuecomment-1009979758
> A general comment about this implementation. > > Referring everything to the Service Configuration is a waste of resource and we should avoid this especially inside synchonized methods. > > I suggest to not evaluate the values of the configuration parameters everything but to try to notify the components that the Configuration changed and to update the current local configuration when such notification happens OK I will fix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
