merlimat commented on a change in pull request #13704:
URL: https://github.com/apache/pulsar/pull/13704#discussion_r782587532



##########
File path: 
pulsar-broker/src/main/java/org/apache/pulsar/broker/stats/prometheus/TransactionAggregator.java
##########
@@ -36,6 +38,11 @@
 @Slf4j
 public class TransactionAggregator {
 
+    /**
+     * Used for tracking duplicate TYPE definitions.
+     */
+    static Map<String, String> metricWithTypeDefinition = new HashMap<>();

Review comment:
       This should be set as a thread-local variable, otherwise multiple 
instances of brokers will clash (eg: during unit tests)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to