shibd commented on pull request #13725: URL: https://github.com/apache/pulsar/pull/13725#issuecomment-1013608168
> About the solution, I still have some concerns. > > In my understanding, the `org.apache.pulsar.metadata.cache.impl.MetadataCacheImpl#refresh` should be always called in the "metadata-store" Thread. Something else must be wrong with callback handling. It does not go through `org.apache.pulsar.metadata.impl.AbstractMetadataStore#execute`. We should fix that instead of adding `synchronized` for `refresh`. You are right. I will solve it according to this idea and resubmit the PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
