wenbingshen opened a new pull request #13767: URL: https://github.com/apache/pulsar/pull/13767
### Motivation When the transactionpending ack replay fails, the current corresponding `PersistentSubscription` is still in the cache. Since the `PendingAckHandleImpl` is only initialized when the `PersistentSubscription` is created, the client still cannot recover after retrying. ### Modifications We should remove the problematic `PendingAckHandleImpl`. For example, we will encounter `PendingAckHandleImpl init fail ` due to `ManagedLedger has already been closed`(You can see this situation from this issue https://github.com/apache/pulsar/issues/13654), so we should allow the client to recover by retrying instead of having to replace the subscription to resume consumption. ### Verifying this change - [ ] Make sure that the change passes the CI checks. *(Please pick either of the following options)* This change is a trivial rework / code cleanup without any test coverage. *(or)* This change is already covered by existing tests, such as *(please describe tests)*. *(or)* This change added tests and can be verified as follows: *(example:)* - *Added integration tests for end-to-end deployment with large payloads (10MB)* - *Extended integration test for recovery after broker failure* ### Does this pull request potentially affect one of the following parts: *If `yes` was chosen, please highlight the changes* - Dependencies (does it add or upgrade a dependency): (yes / no) - The public API: (yes / no) - The schema: (yes / no / don't know) - The default values of configurations: (yes / no) - The wire protocol: (yes / no) - The rest endpoints: (yes / no) - The admin cli options: (yes / no) - Anything that affects deployment: (yes / no / don't know) ### Documentation Check the box below or label this PR directly (if you have committer privilege). Need to update docs? - [ ] `doc-required` (If you need help on updating docs, create a doc issue) - [ ] `no-need-doc` (Please explain why) - [ ] `doc` (If this PR contains doc changes) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
