mattisonchao commented on a change in pull request #13773:
URL: https://github.com/apache/pulsar/pull/13773#discussion_r785426514
##########
File path:
pulsar-broker-common/src/main/java/org/apache/pulsar/broker/authorization/PulsarAuthorizationProvider.java
##########
@@ -228,6 +228,40 @@ public void initialize(ServiceConfiguration conf,
PulsarResources pulsarResource
return allowTheSpecifiedActionOpsAsync(namespaceName, role,
authenticationData, AuthAction.sinks);
}
+ private CompletableFuture<Boolean>
allowConsumeOrProduceOpsAsync(NamespaceName namespaceName,
+ String
role,
+
AuthenticationDataSource authenticationData) {
+ CompletableFuture<Boolean> finalResult = new CompletableFuture<>();
+ allowTheSpecifiedActionOpsAsync(namespaceName, role,
authenticationData, AuthAction.produce)
+ .whenComplete((produceAuthorized, e) -> {
+ if (e == null) {
+ if (produceAuthorized) {
+ finalResult.complete(produceAuthorized);
+ return;
+ }
+ } else {
+ if (log.isDebugEnabled()) {
+ log.debug("Namespace [{}] Role [{}] exception
occurred while trying to check Produce "
+ + "permissions. {}", namespaceName, role,
e.getMessage());
+ }
+ }
+ allowTheSpecifiedActionOpsAsync(namespaceName, role,
authenticationData, AuthAction.consume)
+ .whenComplete((consumeAuthorized, ex) -> {
+ if (ex == null) {
+ finalResult.complete(consumeAuthorized);
+ } else {
+ if (log.isDebugEnabled()) {
+ log.debug("Namespace [{}] Role [{}]
exception occurred while trying to check "
+ + "Consume permissions. {}",
namespaceName, role, ex.getMessage());
+ }
+ finalResult.completeExceptionally(e);
Review comment:
@yuruguo
Something strange here, do we need ``e`` or ``ex`` ?
Besides, we need ``getCause()`` in the exception of CompletableFuture,
otherwise, we will get CompletionException
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
