wolfstudy commented on a change in pull request #708:
URL: https://github.com/apache/pulsar-client-go/pull/708#discussion_r785603239
##########
File path: pulsar/producer_impl.go
##########
@@ -124,6 +126,25 @@ func newProducer(client *client, options *ProducerOptions)
(*producer, error) {
}
}
+ encryption := options.Encryption
+ // add default message crypto if not provided
+ if encryption != nil && len(encryption.Keys) > 0 {
+ if encryption.KeyReader == nil {
Review comment:
It seems that there is no similar check in `newConsumer` and
`newReader`, do they not need it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
