lhotari commented on a change in pull request #12957:
URL: https://github.com/apache/pulsar/pull/12957#discussion_r786548383
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/common/naming/NamespaceBundle.java
##########
@@ -124,7 +124,7 @@ public String getBundleRange() {
return bundleRange;
}
- private static String getKey(NamespaceName nsname, Range<Long> keyRange) {
+ public static String getKey(NamespaceName nsname, Range<Long> keyRange) {
return String.format("%s/0x%08x_0x%08x", nsname,
keyRange.lowerEndpoint(), keyRange.upperEndpoint());
Review comment:
Please don't expose this method because of performance reasons. Instead,
add an instance method "getKey()" to NamespaceBundle so that the cached key
can be retrieved. That seems to be your intention to get the key for the
NamespaceBundle?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
