mattisonchao commented on a change in pull request #13831:
URL: https://github.com/apache/pulsar/pull/13831#discussion_r787572469
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v2/Namespaces.java
##########
@@ -1630,7 +1630,7 @@ public void setSchemaCompatibilityStrategy(
@ApiResponses(value = { @ApiResponse(code = 403, message = "Don't have
admin permission"),
@ApiResponse(code = 404, message = "Namespace doesn't exist"),
@ApiResponse(code = 409, message = "Concurrent modification") })
- public boolean getIsAllowAutoUpdateSchema(
+ public Boolean getIsAllowAutoUpdateSchema(
Review comment:
In my opinion, we need to return a boolean when we define an api to
return a boolean. If not, it is an exception state.
What do you think about this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
