mattisonchao commented on a change in pull request #13887:
URL: https://github.com/apache/pulsar/pull/13887#discussion_r789631947
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java
##########
@@ -4603,16 +4599,18 @@ private void
internalSetReplicatedSubscriptionStatusForNonPartitionedTopic(Async
}
((PersistentTopic)
topic).checkReplicatedSubscriptionControllerState();
- log.info("[{}] Changed replicated subscription status to {} -
{} {}", clientAppId(), enabled, topicName,
+ log.info("[{}] Changed replicated subscription status to {} -
{} {}", clientAppId(), enabled,
+ topicName,
subName);
asyncResponse.resume(Response.noContent().build());
} else {
asyncResponse.resume(new
RestException(Status.METHOD_NOT_ALLOWED,
"Cannot enable/disable replicated subscriptions on
non-persistent topics"));
}
- } catch (Exception e) {
+ }).exceptionally(e -> {
resumeAsyncResponseExceptionally(asyncResponse, e);
Review comment:
- Maybe we need ``e.getCause`` here.
- We need log some information when get exception.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
