mattisonchao commented on a change in pull request #13888:
URL: https://github.com/apache/pulsar/pull/13888#discussion_r789635323



##########
File path: 
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java
##########
@@ -4702,13 +4701,12 @@ protected void 
internalGetReplicatedSubscriptionStatus(AsyncResponse asyncRespon
         }
     }
 
-    private void 
internalGetReplicatedSubscriptionStatusForNonPartitionedTopic(AsyncResponse 
asyncResponse,
+    private CompletableFuture<Void> 
internalGetReplicatedSubscriptionStatusForNonPartitionedTopicAsync(
+                                                                               
AsyncResponse asyncResponse,
                                                                                
String subName,
                                                                                
boolean authoritative) {
-        try {
-            // Redirect the request to the appropriate broker if this broker 
is not the owner of the topic
-            validateTopicOwnership(topicName, authoritative);
-
+        // Redirect the request to the appropriate broker if this broker is 
not the owner of the topic
+        return validateTopicOwnershipAsync(topicName, 
authoritative).thenRun(() -> {
             Topic topic = getTopicReference(topicName);

Review comment:
       This method can be async.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to