This is an automated email from the ASF dual-hosted git repository.

mmerli pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git


The following commit(s) were added to refs/heads/master by this push:
     new 5b39913  PIP-119: Enable consistent hashing by default on KeyShared 
subscriptions dispatcher (#13352)
5b39913 is described below

commit 5b399131b0fc04fbd7c74a1d92e0e803c2e3059c
Author: Qiang Huang <[email protected]>
AuthorDate: Tue Jan 25 09:10:00 2022 +0800

    PIP-119: Enable consistent hashing by default on KeyShared subscriptions 
dispatcher (#13352)
    
    * PIP-119: Enable consistent hashing by default on KeyShared subscriptions 
dispatcher
    
    * Fixed formatting
    
    Co-authored-by: Matteo Merli <[email protected]>
---
 conf/broker.conf                                                      | 2 +-
 conf/standalone.conf                                                  | 2 +-
 deployment/terraform-ansible/templates/broker.conf                    | 2 +-
 .../src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java  | 4 ++--
 4 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/conf/broker.conf b/conf/broker.conf
index 2c14e7d..85efa11 100644
--- a/conf/broker.conf
+++ b/conf/broker.conf
@@ -226,7 +226,7 @@ 
subscriptionTypesEnabled=Exclusive,Shared,Failover,Key_Shared
 
 # On KeyShared subscriptions, with default AUTO_SPLIT mode, use splitting 
ranges or
 # consistent hashing to reassign keys to new consumers
-subscriptionKeySharedUseConsistentHashing=false
+subscriptionKeySharedUseConsistentHashing=true
 
 # On KeyShared subscriptions, number of points in the consistent-hashing ring.
 # The higher the number, the more equal the assignment of keys to consumers
diff --git a/conf/standalone.conf b/conf/standalone.conf
index c289e72..9a72717 100644
--- a/conf/standalone.conf
+++ b/conf/standalone.conf
@@ -138,7 +138,7 @@ subscriptionRedeliveryTrackerEnabled=true
 
 # On KeyShared subscriptions, with default AUTO_SPLIT mode, use splitting 
ranges or
 # consistent hashing to reassign keys to new consumers
-subscriptionKeySharedUseConsistentHashing=false
+subscriptionKeySharedUseConsistentHashing=true
 
 # On KeyShared subscriptions, number of points in the consistent-hashing ring.
 # The higher the number, the more equal the assignment of keys to consumers
diff --git a/deployment/terraform-ansible/templates/broker.conf 
b/deployment/terraform-ansible/templates/broker.conf
index 07e3c7a..b8f741e 100644
--- a/deployment/terraform-ansible/templates/broker.conf
+++ b/deployment/terraform-ansible/templates/broker.conf
@@ -162,7 +162,7 @@ subscriptionKeySharedEnable=true
 
 # On KeyShared subscriptions, with default AUTO_SPLIT mode, use splitting 
ranges or
 # consistent hashing to reassign keys to new consumers
-subscriptionKeySharedUseConsistentHashing=false
+subscriptionKeySharedUseConsistentHashing=true
 
 # On KeyShared subscriptions, number of points in the consistent-hashing ring.
 # The higher the number, the more equal the assignment of keys to consumers
diff --git 
a/pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java
 
b/pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java
index 1e93dc5..98c63c7 100644
--- 
a/pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java
+++ 
b/pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java
@@ -570,8 +570,8 @@ public class ServiceConfiguration implements 
PulsarConfiguration {
 
     @FieldContext(category = CATEGORY_POLICIES,
             doc = "On KeyShared subscriptions, with default AUTO_SPLIT mode, 
use splitting ranges or "
-                    + "consistent hashing to reassign keys to new consumers")
-    private boolean subscriptionKeySharedUseConsistentHashing = false;
+                    + "consistent hashing to reassign keys to new consumers 
(default is consistent hashing)")
+    private boolean subscriptionKeySharedUseConsistentHashing = true;
 
     @FieldContext(
         category = CATEGORY_POLICIES,

Reply via email to