eolivelli commented on a change in pull request #13891:
URL: https://github.com/apache/pulsar/pull/13891#discussion_r792643068
##########
File path:
pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java
##########
@@ -2580,7 +2581,14 @@ public String getBookkeeperMetadataStoreUrl() {
} else {
// Fallback to same metadata service used by broker, adding the
"metadata-store" to specify the BK
// metadata adapter
- return "metadata-store:" + getMetadataStoreUrl();
+ String suffix;
+ if (StringUtils.isNotBlank(metadataStoreUrl)) {
+ suffix = metadataStoreUrl;
+ } else {
+ // Fallback to old setting
+ suffix = "zk:" + zookeeperServers + new
ClientConfiguration().getZkLedgersRootPath();
Review comment:
should we use some utility method in ClientConfiguration ?
or build a dummy ClientConfiguration and use BK functions to compute the
value ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
