congbobo184 commented on a change in pull request #13957:
URL: https://github.com/apache/pulsar/pull/13957#discussion_r792812580



##########
File path: 
pulsar-transaction/coordinator/src/main/java/org/apache/pulsar/transaction/coordinator/impl/MLTransactionMetadataStoreProvider.java
##########
@@ -48,8 +48,10 @@
                 managedLedgerFactory, managedLedgerConfig);
 
         // MLTransactionLogInterceptor will init sequenceId and update the 
sequenceId to managedLedger properties.
-        return txnLog.initialize().thenApply(__ ->

Review comment:
       move  
   ```
           if (!changeToInitializingState()) {
               log.error("Managed ledger transaction metadata store change 
state error when init it");
               return;
           }
   ```
   to init method.
   
   when`changeToReadyState() == false` we should return 
`completableFuture.completeExceptionally(new 
TransactionNotFoundException(txnID));` and client will reonnect 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to