gaoran10 commented on a change in pull request #13833:
URL: https://github.com/apache/pulsar/pull/13833#discussion_r793429350
##########
File path:
tiered-storage/jcloud/src/main/java/org/apache/bookkeeper/mledger/offload/jcloud/impl/BlobStoreBackedReadHandleImpl.java
##########
@@ -145,6 +151,7 @@ public LedgerMetadata getLedgerMetadata() {
}
entriesToRead--;
nextExpectedId++;
+ this.mxBean.recordReadOffloadBytes(managedLedgerName,
length);
Review comment:
I'm not sure about the metrics `readOffloadBytes`, it indicates retrieve
data length from tiered storage or the ledger read data length.
Here we may encounter exceptions, then we can't collect the data length, and
we need to handle different conditions here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
