hangc0276 commented on a change in pull request #13782:
URL: https://github.com/apache/pulsar/pull/13782#discussion_r794145219
##########
File path: site2/docs/functions-runtime.md
##########
@@ -270,7 +270,7 @@ For example, if you use token authentication, you need to
configure the followin
```Yaml
clientAuthenticationPlugin:
org.apache.pulsar.client.impl.auth.AuthenticationToken
clientAuthenticationParameters: file:///etc/pulsar/token/admin-token.txt
-configurationStoreServers: zookeeper-cluster:2181 # auth requires a connection
to zookeeper
+configurationMetadataStoreUrl: zookeeper-cluster:2181 # auth requires a
connection to zookeeper
Review comment:
`configurationMetadataStoreUrl: zk:zookeeper-cluster:2181` is better
##########
File path:
pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/worker/WorkerConfig.java
##########
@@ -147,6 +147,12 @@
doc = "Configuration store connection string (as a comma-separated
list)"
)
private String configurationStoreServers;
Review comment:
Mark `configurationStoreServers` deprecated?
##########
File path: site2/docs/functions-worker.md
##########
@@ -216,12 +216,12 @@ properties:
##### Enable Authorization Provider
-To enable authorization on Functions Worker, you need to configure
`authorizationEnabled`, `authorizationProvider` and
`configurationStoreServers`. The authentication provider connects to
`configurationStoreServers` to receive namespace policies.
+To enable authorization on Functions Worker, you need to configure
`authorizationEnabled`, `authorizationProvider` and
`configurationMetadataStoreUrl`. The authentication provider connects to
`configurationMetadataStoreUrl` to receive namespace policies.
```yaml
authorizationEnabled: true
authorizationProvider:
org.apache.pulsar.broker.authorization.PulsarAuthorizationProvider
-configurationStoreServers: <configuration-store-servers>
+configurationMetadataStoreUrl: <configuration-store-servers>
Review comment:
`configurationMetadataStoreUrl:
<meta-type>:<configuration-store-servers>` is better
##########
File path: site2/website-next/docs/functions-worker.md
##########
@@ -235,13 +235,13 @@ properties:
##### Enable Authorization Provider
-To enable authorization on Functions Worker, you need to configure
`authorizationEnabled`, `authorizationProvider` and
`configurationStoreServers`. The authentication provider connects to
`configurationStoreServers` to receive namespace policies.
+To enable authorization on Functions Worker, you need to configure
`authorizationEnabled`, `authorizationProvider` and
`configurationMetadataStoreUrl`. The authentication provider connects to
`configurationMetadataStoreUrl` to receive namespace policies.
```yaml
authorizationEnabled: true
authorizationProvider:
org.apache.pulsar.broker.authorization.PulsarAuthorizationProvider
-configurationStoreServers: <configuration-store-servers>
+configurationMetadataStoreUrl: <configuration-store-servers>
Review comment:
the same above
##########
File path: site2/website-next/docs/functions-runtime.md
##########
@@ -292,7 +292,7 @@ For example, if you use token authentication, you need to
configure the followin
clientAuthenticationPlugin:
org.apache.pulsar.client.impl.auth.AuthenticationToken
clientAuthenticationParameters: file:///etc/pulsar/token/admin-token.txt
-configurationStoreServers: zookeeper-cluster:2181 # auth requires a connection
to zookeeper
+configurationMetadataStoreUrl: zookeeper-cluster:2181 # auth requires a
connection to zookeeper
Review comment:
the same above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
