Anonymitaet commented on a change in pull request #13983:
URL: https://github.com/apache/pulsar/pull/13983#discussion_r794297154
##########
File path: conf/broker.conf
##########
@@ -1283,16 +1284,12 @@ splitTopicAndPartitionLabelInPrometheus=false
# The schema storage implementation used by this broker
schemaRegistryStorageClassName=org.apache.pulsar.broker.service.schema.BookkeeperSchemaStorageFactory
-# Enforce schema validation on following cases:
-#
-# - if a producer without a schema attempts to produce to a topic with schema,
the producer will be
-# failed to connect. PLEASE be carefully on using this, since non-java
clients don't support schema.
-# if you enable this setting, it will cause non-java clients failed to
produce.
+# Whether to enable schema validation.
+# When enabled, if a producer without a schema attempts to produce to a topic
with schema, the producer will be rejected and disconnected.
Review comment:
```suggestion
# When schema validation is enabled, if a producer without a schema attempts
to produce to a topic with a schema, the producer is rejected and disconnected.
```
1. or "produce to a topic with schemas"?
2. Write in the simple present tense as much as possible if you are covering
facts that were, are, and forever shall be true. Details:
https://docs.google.com/document/d/1lc5j4RtuLIzlEYCBo97AC8-U_3Erzs_lxpkDuseU0n4/edit#bookmark=id.e8uqh1awkcnp
##########
File path: conf/broker.conf
##########
@@ -561,7 +561,8 @@ zookeeperSessionExpiredPolicy=shutdown
# Enable or disable system topic
systemTopicEnabled=false
-# The schema compatibility strategy to use for system topics
+# The schema compatibility strategy to use for system topics.
Review comment:
```suggestion
# The schema compatibility strategy used for system topics.
```
do you mean this?
##########
File path: site2/docs/reference-configuration.md
##########
@@ -671,6 +674,11 @@ You can set the log level and configuration in the
[log4j2.yaml](https://github
|haProxyProtocolEnabled | Enable or disable the
[HAProxy](http://www.haproxy.org/) protocol. |false|
|bookieId | If you want to custom a bookie ID or use a dynamic network address
for a bookie, you can set the `bookieId`. <br><br>Bookie advertises itself
using the `bookieId` rather than the `BookieSocketAddress` (`hostname:port` or
`IP:port`).<br><br> The `bookieId` is a non-empty string that can contain ASCII
digits and letters ([a-zA-Z9-0]), colons, dashes, and dots. <br><br>For more
information about `bookieId`, see
[here](http://bookkeeper.apache.org/bps/BP-41-bookieid/).|/|
| maxTopicsPerNamespace | The maximum number of persistent topics that can be
created in the namespace. When the number of topics reaches this threshold, the
broker rejects the request of creating a new topic, including the auto-created
topics by the producer or consumer, until the number of connected consumers
decreases. The default value 0 disables the check. | 0 |
+|schemaRegistryStorageClassName|The schema storage implementation used by this
broker.|org.apache.pulsar.broker.service.schema.BookkeeperSchemaStorageFactory|
+|isSchemaValidationEnforced| Whether to enable schema validation, when
enabled, if a producer without a schema attempts to produce to a topic with
schema, the producer will be rejected and disconnected.|false|
+|isAllowAutoUpdateSchemaEnabled|Allow schema to be auto updated at broker
level|true|
+|schemaCompatibilityStrategy|Schema compatibility check strategy. Available
values:
`ALWAYS_COMPATIBLE`,`ALWAYS_INCOMPATIBLE`,`BACKWARD`,`BACKWARD_TRANSITIVE`,`FORWARD`,`FORWARD_TRANSITIVE`,`FULL`,`FULL_TRANSITIVE`|FULL|
+|systemTopicSchemaCompatibilityStrategy|The schema compatibility strategy to
use for system topics. Available values:
`ALWAYS_COMPATIBLE`,`ALWAYS_INCOMPATIBLE`,`BACKWARD`,`BACKWARD_TRANSITIVE`,`FORWARD`,`FORWARD_TRANSITIVE`,`FULL`,`FULL_TRANSITIVE`|ALWAYS_COMPATIBLE|
Review comment:
```suggestion
|systemTopicSchemaCompatibilityStrategy|The schema compatibility strategy to
use for system topics. Available values:
`ALWAYS_COMPATIBLE`,`ALWAYS_INCOMPATIBLE`,`BACKWARD`,`BACKWARD_TRANSITIVE`,`FORWARD`,`FORWARD_TRANSITIVE`,`FULL`,`FULL_TRANSITIVE`|`ALWAYS_COMPATIBLE`|
```
##########
File path: conf/broker.conf
##########
@@ -561,7 +561,8 @@ zookeeperSessionExpiredPolicy=shutdown
# Enable or disable system topic
systemTopicEnabled=false
-# The schema compatibility strategy to use for system topics
+# The schema compatibility strategy to use for system topics.
+# Available values: ALWAYS_INCOMPATIBLE, ALWAYS_COMPATIBLE, BACKWARD, FORWARD,
FULL, BACKWARD_TRANSITIVE, FORWARD_TRANSITIVE, FULL_TRANSITIVE
Review comment:
please keep consistent overall
```suggestion
# Available values: `ALWAYS_INCOMPATIBLE`, `ALWAYS_COMPATIBLE`, `BACKWARD`,
`FORWARD`, `FULL`, `BACKWARD_TRANSITIVE`, `FORWARD_TRANSITIVE`,
`FULL_TRANSITIVE`
```
##########
File path: conf/standalone.conf
##########
@@ -433,6 +433,10 @@ brokerClientTlsProtocols=
# Enable or disable system topic
systemTopicEnabled=false
+# The schema compatibility strategy to use for system topics.
+# Available values: ALWAYS_INCOMPATIBLE, ALWAYS_COMPATIBLE, BACKWARD, FORWARD,
FULL, BACKWARD_TRANSITIVE, FORWARD_TRANSITIVE, FULL_TRANSITIVE
Review comment:
please keep consistent overall (add backticks)
##########
File path: site2/docs/reference-configuration.md
##########
@@ -250,7 +250,10 @@ brokerServiceCompactionThresholdInBytes|If the estimated
backlog size is greater
|athenzDomainNames| Supported Athenz provider domain names(comma separated)
for authentication ||
|exposePreciseBacklogInPrometheus| Enable expose the precise backlog stats,
set false to use published counter and consumed counter to calculate, this
would be more efficient but may be inaccurate. |false|
|schemaRegistryStorageClassName|The schema storage implementation used by this
broker.|org.apache.pulsar.broker.service.schema.BookkeeperSchemaStorageFactory|
-|isSchemaValidationEnforced|Enforce schema validation on following cases: if a
producer without a schema attempts to produce to a topic with schema, the
producer will be failed to connect. PLEASE be carefully on using this, since
non-java clients don't support schema. If this setting is enabled, then
non-java clients fail to produce.|false|
+|isSchemaValidationEnforced| Whether to enable schema validation, when
enabled, if a producer without a schema attempts to produce to a topic with
schema, the producer will be rejected and disconnected.|false|
Review comment:
same
##########
File path: conf/standalone.conf
##########
@@ -433,6 +433,10 @@ brokerClientTlsProtocols=
# Enable or disable system topic
systemTopicEnabled=false
+# The schema compatibility strategy to use for system topics.
Review comment:
same comment
##########
File path: site2/docs/reference-configuration.md
##########
@@ -671,6 +674,11 @@ You can set the log level and configuration in the
[log4j2.yaml](https://github
|haProxyProtocolEnabled | Enable or disable the
[HAProxy](http://www.haproxy.org/) protocol. |false|
|bookieId | If you want to custom a bookie ID or use a dynamic network address
for a bookie, you can set the `bookieId`. <br><br>Bookie advertises itself
using the `bookieId` rather than the `BookieSocketAddress` (`hostname:port` or
`IP:port`).<br><br> The `bookieId` is a non-empty string that can contain ASCII
digits and letters ([a-zA-Z9-0]), colons, dashes, and dots. <br><br>For more
information about `bookieId`, see
[here](http://bookkeeper.apache.org/bps/BP-41-bookieid/).|/|
| maxTopicsPerNamespace | The maximum number of persistent topics that can be
created in the namespace. When the number of topics reaches this threshold, the
broker rejects the request of creating a new topic, including the auto-created
topics by the producer or consumer, until the number of connected consumers
decreases. The default value 0 disables the check. | 0 |
+|schemaRegistryStorageClassName|The schema storage implementation used by this
broker.|org.apache.pulsar.broker.service.schema.BookkeeperSchemaStorageFactory|
+|isSchemaValidationEnforced| Whether to enable schema validation, when
enabled, if a producer without a schema attempts to produce to a topic with
schema, the producer will be rejected and disconnected.|false|
+|isAllowAutoUpdateSchemaEnabled|Allow schema to be auto updated at broker
level|true|
Review comment:
```suggestion
|isAllowAutoUpdateSchemaEnabled|Allow schema to be auto updated at broker
level.|true|
```
##########
File path: conf/standalone.conf
##########
@@ -907,6 +911,18 @@ exposePreciseBacklogInPrometheus=false
splitTopicAndPartitionLabelInPrometheus=false
+### --- Schema storage --- ###
+# The schema storage implementation used by this broker.
+schemaRegistryStorageClassName=org.apache.pulsar.broker.service.schema.BookkeeperSchemaStorageFactory
+
+# Whether to enable schema validation.
+# When enabled, if a producer without a schema attempts to produce to a topic
with schema, the producer will be rejected and disconnected.
Review comment:
same
##########
File path: conf/standalone.conf
##########
@@ -907,6 +911,18 @@ exposePreciseBacklogInPrometheus=false
splitTopicAndPartitionLabelInPrometheus=false
+### --- Schema storage --- ###
+# The schema storage implementation used by this broker.
+schemaRegistryStorageClassName=org.apache.pulsar.broker.service.schema.BookkeeperSchemaStorageFactory
+
+# Whether to enable schema validation.
+# When enabled, if a producer without a schema attempts to produce to a topic
with schema, the producer will be rejected and disconnected.
+isSchemaValidationEnforced=false
+
+# The schema compatibility strategy in broker level.
Review comment:
```suggestion
# The schema compatibility strategy at broker level.
```
##########
File path: site2/docs/reference-configuration.md
##########
@@ -671,6 +674,11 @@ You can set the log level and configuration in the
[log4j2.yaml](https://github
|haProxyProtocolEnabled | Enable or disable the
[HAProxy](http://www.haproxy.org/) protocol. |false|
|bookieId | If you want to custom a bookie ID or use a dynamic network address
for a bookie, you can set the `bookieId`. <br><br>Bookie advertises itself
using the `bookieId` rather than the `BookieSocketAddress` (`hostname:port` or
`IP:port`).<br><br> The `bookieId` is a non-empty string that can contain ASCII
digits and letters ([a-zA-Z9-0]), colons, dashes, and dots. <br><br>For more
information about `bookieId`, see
[here](http://bookkeeper.apache.org/bps/BP-41-bookieid/).|/|
| maxTopicsPerNamespace | The maximum number of persistent topics that can be
created in the namespace. When the number of topics reaches this threshold, the
broker rejects the request of creating a new topic, including the auto-created
topics by the producer or consumer, until the number of connected consumers
decreases. The default value 0 disables the check. | 0 |
+|schemaRegistryStorageClassName|The schema storage implementation used by this
broker.|org.apache.pulsar.broker.service.schema.BookkeeperSchemaStorageFactory|
+|isSchemaValidationEnforced| Whether to enable schema validation, when
enabled, if a producer without a schema attempts to produce to a topic with
schema, the producer will be rejected and disconnected.|false|
+|isAllowAutoUpdateSchemaEnabled|Allow schema to be auto updated at broker
level|true|
+|schemaCompatibilityStrategy|Schema compatibility check strategy. Available
values:
`ALWAYS_COMPATIBLE`,`ALWAYS_INCOMPATIBLE`,`BACKWARD`,`BACKWARD_TRANSITIVE`,`FORWARD`,`FORWARD_TRANSITIVE`,`FULL`,`FULL_TRANSITIVE`|FULL|
Review comment:
```suggestion
|schemaCompatibilityStrategy|Schema compatibility check strategy. Available
values:
`ALWAYS_COMPATIBLE`,`ALWAYS_INCOMPATIBLE`,`BACKWARD`,`BACKWARD_TRANSITIVE`,`FORWARD`,`FORWARD_TRANSITIVE`,`FULL`,`FULL_TRANSITIVE`|`FULL`|
```
##########
File path: site2/docs/reference-configuration.md
##########
@@ -671,6 +674,11 @@ You can set the log level and configuration in the
[log4j2.yaml](https://github
|haProxyProtocolEnabled | Enable or disable the
[HAProxy](http://www.haproxy.org/) protocol. |false|
|bookieId | If you want to custom a bookie ID or use a dynamic network address
for a bookie, you can set the `bookieId`. <br><br>Bookie advertises itself
using the `bookieId` rather than the `BookieSocketAddress` (`hostname:port` or
`IP:port`).<br><br> The `bookieId` is a non-empty string that can contain ASCII
digits and letters ([a-zA-Z9-0]), colons, dashes, and dots. <br><br>For more
information about `bookieId`, see
[here](http://bookkeeper.apache.org/bps/BP-41-bookieid/).|/|
| maxTopicsPerNamespace | The maximum number of persistent topics that can be
created in the namespace. When the number of topics reaches this threshold, the
broker rejects the request of creating a new topic, including the auto-created
topics by the producer or consumer, until the number of connected consumers
decreases. The default value 0 disables the check. | 0 |
+|schemaRegistryStorageClassName|The schema storage implementation used by this
broker.|org.apache.pulsar.broker.service.schema.BookkeeperSchemaStorageFactory|
+|isSchemaValidationEnforced| Whether to enable schema validation, when
enabled, if a producer without a schema attempts to produce to a topic with
schema, the producer will be rejected and disconnected.|false|
Review comment:
same
##########
File path: conf/broker.conf
##########
@@ -1283,16 +1284,12 @@ splitTopicAndPartitionLabelInPrometheus=false
# The schema storage implementation used by this broker
schemaRegistryStorageClassName=org.apache.pulsar.broker.service.schema.BookkeeperSchemaStorageFactory
-# Enforce schema validation on following cases:
-#
-# - if a producer without a schema attempts to produce to a topic with schema,
the producer will be
-# failed to connect. PLEASE be carefully on using this, since non-java
clients don't support schema.
-# if you enable this setting, it will cause non-java clients failed to
produce.
+# Whether to enable schema validation.
+# When enabled, if a producer without a schema attempts to produce to a topic
with schema, the producer will be rejected and disconnected.
isSchemaValidationEnforced=false
# The schema compatibility strategy in broker level.
-# SchemaCompatibilityStrategy : ALWAYS_INCOMPATIBLE, ALWAYS_COMPATIBLE,
BACKWARD, FORWARD,
-# FULL, BACKWARD_TRANSITIVE, FORWARD_TRANSITIVE, FULL_TRANSITIVE
+# Available values: ALWAYS_INCOMPATIBLE, ALWAYS_COMPATIBLE, BACKWARD, FORWARD,
FULL, BACKWARD_TRANSITIVE, FORWARD_TRANSITIVE, FULL_TRANSITIVE
Review comment:
please keep consistent overall (add backticks)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
