gaozhangmin commented on pull request #13621:
URL: https://github.com/apache/pulsar/pull/13621#issuecomment-1024021438


   > This is to also fix [issues like 
this](https://github.com/apache/pulsar/runs/4714481351?check_suite_focus=true#step:9:551):
   > 
   > ```
   > Error:  Tests run: 69, Failures: 1, Errors: 0, Skipped: 55, Time elapsed: 
11.343 s <<< FAILURE! - in 
org.apache.pulsar.broker.service.persistent.PersistentTopicStreamingDispatcherTest
   > Error:  
setup(org.apache.pulsar.broker.service.persistent.PersistentTopicStreamingDispatcherTest)
  Time elapsed: 0.107 s  <<< FAILURE!
   > org.mockito.exceptions.base.MockitoException: Unable to create mock 
instance of type 'ServerCnx'
   >    at 
org.apache.pulsar.broker.service.PersistentTopicTest.setup(PersistentTopicTest.java:211)
   >    at 
org.apache.pulsar.broker.service.persistent.PersistentTopicStreamingDispatcherTest.setup(PersistentTopicStreamingDispatcherTest.java:34)
   >    at 
org.testng.internal.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:132)
   >    at 
org.testng.internal.MethodInvocationHelper.invokeMethodConsideringTimeout(MethodInvocationHelper.java:61)
   >    at 
org.testng.internal.ConfigInvoker.invokeConfigurationMethod(ConfigInvoker.java:366)
   >    at 
org.testng.internal.ConfigInvoker.invokeConfigurations(ConfigInvoker.java:320)
   >    at 
org.testng.internal.TestInvoker.runConfigMethods(TestInvoker.java:701)
   >    at org.testng.internal.TestInvoker.invokeMethod(TestInvoker.java:527)
   >    at 
org.testng.internal.TestInvoker.invokeTestMethod(TestInvoker.java:174)
   >    at org.testng.internal.MethodRunner.runInSequence(MethodRunner.java:46)
   >    at 
org.testng.internal.TestInvoker$MethodInvocationAgent.invoke(TestInvoker.java:822)
   >    at 
org.testng.internal.TestInvoker.invokeTestMethods(TestInvoker.java:147)
   >    at 
org.testng.internal.TestMethodWorker.invokeTestMethods(TestMethodWorker.java:146)
   >    at org.testng.internal.TestMethodWorker.run(TestMethodWorker.java:128)
   >    at java.base/java.util.ArrayList.forEach(ArrayList.java:1541)
   >    at org.testng.TestRunner.privateRun(TestRunner.java:764)
   >    at org.testng.TestRunner.run(TestRunner.java:585)
   >    at org.testng.SuiteRunner.runTest(SuiteRunner.java:384)
   >    at org.testng.SuiteRunner.runSequentially(SuiteRunner.java:378)
   >    at org.testng.SuiteRunner.privateRun(SuiteRunner.java:337)
   >    at org.testng.SuiteRunner.run(SuiteRunner.java:286)
   >    at org.testng.SuiteRunnerWorker.runSuite(SuiteRunnerWorker.java:53)
   >    at org.testng.SuiteRunnerWorker.run(SuiteRunnerWorker.java:96)
   >    at org.testng.TestNG.runSuitesSequentially(TestNG.java:1218)
   >    at org.testng.TestNG.runSuitesLocally(TestNG.java:1140)
   >    at org.testng.TestNG.runSuites(TestNG.java:1069)
   >    at org.testng.TestNG.run(TestNG.java:1037)
   >    at 
org.apache.maven.surefire.testng.TestNGExecutor.run(TestNGExecutor.java:135)
   >    at 
org.apache.maven.surefire.testng.TestNGDirectoryTestSuite.executeSingleClass(TestNGDirectoryTestSuite.java:112)
   >    at 
org.apache.maven.surefire.testng.TestNGDirectoryTestSuite.executeLazy(TestNGDirectoryTestSuite.java:123)
   >    at 
org.apache.maven.surefire.testng.TestNGDirectoryTestSuite.execute(TestNGDirectoryTestSuite.java:90)
   >    at 
org.apache.maven.surefire.testng.TestNGProvider.invoke(TestNGProvider.java:146)
   >    at 
org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:384)
   >    at 
org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:345)
   >    at 
org.apache.maven.surefire.booter.ForkedBooter.execute(ForkedBooter.java:126)
   >    at 
org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:418)
   > Caused by: org.mockito.creation.instance.InstantiationException: 
   > Unable to create instance of 'ServerCnx$MockitoMock$1579413196'.
   > Please ensure the target class has a constructor that matches these 
argument types: [org.apache.pulsar.broker.PulsarService$MockitoMock$1968480223] 
and executes cleanly.
   >    ... 36 more
   > Caused by: java.lang.reflect.InvocationTargetException
   >    at 
jdk.internal.reflect.GeneratedConstructorAccessor231.newInstance(Unknown Source)
   >    at 
java.base/jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
   >    at 
java.base/java.lang.reflect.Constructor.newInstance(Constructor.java:490)
   >    at 
org.mockito.internal.util.reflection.ReflectionMemberAccessor.lambda$newInstance$0(ReflectionMemberAccessor.java:26)
   >    at 
org.mockito.internal.util.reflection.ReflectionMemberAccessor.newInstance(ReflectionMemberAccessor.java:26)
   >    at 
org.mockito.internal.util.reflection.ReflectionMemberAccessor.newInstance(ReflectionMemberAccessor.java:17)
   >    at 
org.mockito.internal.creation.instance.ConstructorInstantiator.invokeConstructor(ConstructorInstantiator.java:69)
   >    at 
org.mockito.internal.creation.instance.ConstructorInstantiator.withParams(ConstructorInstantiator.java:52)
   >    at 
org.mockito.internal.creation.instance.ConstructorInstantiator.newInstance(ConstructorInstantiator.java:38)
   >    at 
org.mockito.internal.creation.bytebuddy.SubclassByteBuddyMockMaker.createMock(SubclassByteBuddyMockMaker.java:48)
   >    at 
org.mockito.internal.creation.bytebuddy.ByteBuddyMockMaker.createMock(ByteBuddyMockMaker.java:29)
   >    at 
org.powermock.api.mockito.mockmaker.PowerMockMaker.createMock(PowerMockMaker.java:41)
   >    at org.mockito.internal.util.MockUtil.createMock(MockUtil.java:53)
   >    at org.mockito.internal.MockitoCore.mock(MockitoCore.java:62)
   >    at org.mockito.Mockito.mock(Mockito.java:1951)
   >    at 
org.apache.pulsar.broker.service.PersistentTopicTest.setup(PersistentTopicTest.java:211)
   >    at 
org.apache.pulsar.broker.service.persistent.PersistentTopicStreamingDispatcherTest.setup(PersistentTopicStreamingDispatcherTest.java:34)
   >    at 
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
   >    at 
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
   >    at 
java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
   >    at java.base/java.lang.reflect.Method.invoke(Method.java:566)
   >    ... 34 more
   > Caused by: java.lang.NullPointerException
   >    at org.apache.pulsar.broker.service.ServerCnx.<init>(ServerCnx.java:233)
   >    at org.apache.pulsar.broker.service.ServerCnx.<init>(ServerCnx.java:229)
   >    at 
org.apache.pulsar.broker.service.ServerCnx$MockitoMock$1579413196.<init>(Unknown
 Source)
   >    ... 55 more
   > ```
   > 
   > This problem persisted after making #13608 change.
   
   @lhotari I still can get this flaky test. 
https://github.com/apache/pulsar/runs/4976572806?check_suite_focus=true


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to