michaeljmarshall commented on a change in pull request #13993:
URL: https://github.com/apache/pulsar/pull/13993#discussion_r794875265
##########
File path:
pulsar-client/src/main/java/org/apache/pulsar/client/impl/Backoff.java
##########
@@ -22,29 +22,59 @@
import java.time.Clock;
import java.util.Random;
import java.util.concurrent.TimeUnit;
-import lombok.Data;
+import lombok.Getter;
-// All variables are in TimeUnit millis by default
-@Data
Review comment:
I don't see any use for equality checking of `Backoff` objects outside
of reference equality, and calling `toString` on the class is going to log a
lot of information. I am leaning towards just removing these annotations. If we
really want `toString`, I can write one in the class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
