mattisonchao commented on a change in pull request #14045:
URL: https://github.com/apache/pulsar/pull/14045#discussion_r795108318
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v1/PersistentTopics.java
##########
@@ -480,12 +480,13 @@ public void skipAllMessages(@Suspended final
AsyncResponse asyncResponse, @PathP
@ApiResponse(code = 307, message = "Current broker doesn't serve
the namespace of this topic"),
@ApiResponse(code = 403, message = "Don't have admin permission"),
@ApiResponse(code = 404, message = "Topic or subscription does not
exist") })
- public void skipMessages(@PathParam("property") String property,
@PathParam("cluster") String cluster,
- @PathParam("namespace") String namespace, @PathParam("topic")
@Encoded String encodedTopic,
- @PathParam("subName") String encodedSubName,
@PathParam("numMessages") int numMessages,
+ public void skipMessages(@Suspended final AsyncResponse asyncResponse,
@PathParam("property") String property,
+ @PathParam("cluster") String cluster, @PathParam("namespace")
String namespace,
+ @PathParam("topic") @Encoded String encodedTopic,
@PathParam("subName") String encodedSubName,
+ @PathParam("numMessages") int numMessages,
@QueryParam("authoritative") @DefaultValue("false") boolean
authoritative) {
validateTopicName(property, cluster, namespace, encodedTopic);
Review comment:
Since we're using asyncResponse, do we need to check for exceptions at
validateTopicName ?
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v2/PersistentTopics.java
##########
@@ -1202,7 +1203,7 @@ public void skipMessages(
@ApiParam(value = "Is authentication required to perform this
operation")
@QueryParam("authoritative") @DefaultValue("false") boolean
authoritative) {
validateTopicName(tenant, namespace, encodedTopic);
Review comment:
same above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
