Jason918 commented on a change in pull request #14038:
URL: https://github.com/apache/pulsar/pull/14038#discussion_r795301796
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/AbstractTopic.java
##########
@@ -224,6 +231,20 @@ protected void updateTopicPolicyByNamespacePolicy(Policies
namespacePolicies) {
type -> this.topicPolicies.getBackLogQuotaMap().get(type)
.updateNamespaceValue(MapUtils.getObject(namespacePolicies.backlog_quota_map,
type)));
updateSchemaCompatibilityStrategyNamespaceValue(namespacePolicies);
+ updateNamespaceDispatchRate(namespacePolicies,
brokerService.getPulsar().getConfig().getClusterName());
+ }
+
+ private void updateNamespaceDispatchRate(Policies namespacePolicies,
String cluster) {
+ DispatchRateImpl dispatchRate =
namespacePolicies.topicDispatchRate.get(cluster);
+ if (dispatchRate == null) {
+ dispatchRate = namespacePolicies.clusterDispatchRate.get(cluster);
+ }
+
topicPolicies.getDispatchRate().updateNamespaceValue(isDispatchRateEnabled(dispatchRate)
? dispatchRate : null);
Review comment:
We can do a normalize(dispatchRate) before all level assignment.
```
private boolean normalize(DispatchRate dispatchRate) {
if ( dispatchRate != null &&
(dispatchRate.getDispatchThrottlingRateInMsg() > 0
|| dispatchRate.getDispatchThrottlingRateInByte() > 0)) {
return dispatchRate;
} else {
return null;
}
}
```
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/DispatchRateLimiter.java
##########
@@ -169,6 +169,25 @@ private DispatchRate createDispatchRate() {
* broker-level
*/
public void updateDispatchRate() {
+ final ServiceConfiguration serviceConfiguration =
brokerService.pulsar().getConfiguration();
+ if (serviceConfiguration.isSystemTopicEnabled() &&
serviceConfiguration.isTopicLevelPoliciesEnabled()) {
+ DispatchRate dispatchRateValue = null;
+ switch (type) {
+ case TOPIC:
+ dispatchRateValue = topic.getDispatchRate();
+ }
+ if (type == Type.BROKER) {
Review comment:
Why do we need to handle broker type here ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
