merlimat commented on a change in pull request #14078:
URL: https://github.com/apache/pulsar/pull/14078#discussion_r795831403
##########
File path:
pulsar-proxy/src/main/java/org/apache/pulsar/proxy/server/ProxyConnection.java
##########
@@ -481,6 +504,30 @@ public HAProxyMessage getHAProxyMessage() {
return haProxyMessage;
}
- private static final Logger LOG =
LoggerFactory.getLogger(ProxyConnection.class);
+ private boolean isBrokerActive(String targetBrokerHostPort) {
+ for (ServiceLookupData serviceLookupData : getAvailableBrokers()) {
+ if (matchesHostAndPort("pulsar://",
serviceLookupData.getPulsarServiceUrl(), targetBrokerHostPort)
+ || matchesHostAndPort("pulsar+ssl://",
serviceLookupData.getPulsarServiceUrlTls(),
+ targetBrokerHostPort)) {
+ return true;
+ }
+ }
+ return false;
+ }
+
+ private List<? extends ServiceLookupData> getAvailableBrokers() {
+ try {
+ return service.getDiscoveryProvider().getAvailableBrokers();
Review comment:
This would not work if proxy doesn't have a ZK connection (which is the
most common way to configure it).
(It would actually trigger an NPE here).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
