rdhabalia commented on a change in pull request #901: Introduce configuration
converter
URL: https://github.com/apache/incubator-pulsar/pull/901#discussion_r150950022
##########
File path:
pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java
##########
@@ -1272,4 +1274,28 @@ public void setPreferLaterVersions(boolean
preferLaterVersions) {
public int getWebSocketConnectionsPerBroker() { return
webSocketConnectionsPerBroker; }
public void setWebSocketConnectionsPerBroker(int
webSocketConnectionsPerBroker) { this.webSocketConnectionsPerBroker =
webSocketConnectionsPerBroker; }
+
+ public static ServiceConfiguration convertFrom(PulsarConfiguration conf)
throws RuntimeException {
Review comment:
and should we also add overloaded method `convertFrom(PulsarConfiguration
conf, boolean ignoreNonExistMember)` which will not throw `RuntimeException` if
the name is different or few of the fields are not present into
`ServiceConfiguration` and present into given `PulsarConfiguration`. ??
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
