yush1ga commented on a change in pull request #901: Introduce configuration
converter
URL: https://github.com/apache/incubator-pulsar/pull/901#discussion_r150965286
##########
File path:
pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java
##########
@@ -1272,4 +1274,28 @@ public void setPreferLaterVersions(boolean
preferLaterVersions) {
public int getWebSocketConnectionsPerBroker() { return
webSocketConnectionsPerBroker; }
public void setWebSocketConnectionsPerBroker(int
webSocketConnectionsPerBroker) { this.webSocketConnectionsPerBroker =
webSocketConnectionsPerBroker; }
+
+ public static ServiceConfiguration convertFrom(PulsarConfiguration conf)
throws RuntimeException {
Review comment:
I added the argument `ignoreNonExistMember` and the overloaded method.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
