rdhabalia commented on a change in pull request #689: Netty 4.1
URL: https://github.com/apache/incubator-pulsar/pull/689#discussion_r153638970
##########
File path:
pulsar-common/src/main/java/org/apache/pulsar/common/util/protobuf/ByteBufCodedOutputStream.java
##########
@@ -261,7 +260,6 @@ static int makeTag(final int fieldNumber, final int
wireType) {
/** Write an double field, including tag, to the stream. */
public void writeDouble(final int fieldNumber, double value) throws
IOException {
writeTag(fieldNumber, WireFormat.WIRETYPE_FIXED64);
- buf.order(ByteOrder.LITTLE_ENDIAN).writeDouble(value);
+ buf.writeLongLE(Double.doubleToLongBits(value));
Review comment:
don't we have a way to preserve double value instead casting to long?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
