ivankelly commented on a change in pull request #1066: Issue 937: add CommandGetLastMessageId to make reader know the end of topic URL: https://github.com/apache/incubator-pulsar/pull/1066#discussion_r162066693
########## File path: managed-ledger/src/main/java/org/apache/bookkeeper/mledger/ManagedLedger.java ########## @@ -323,14 +321,16 @@ public boolean isTerminated(); /** - * Returns managed-ledger config + * Returns managed-ledger config */ ManagedLedgerConfig getConfig(); /** * Updates managed-ledger config - * + * * @param config */ void setConfig(ManagedLedgerConfig config); + + Position getLastConfirmedEntry(); Review comment: Needs javadoc ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services