yush1ga commented on a change in pull request #1087: Add basic authentication 
plugin
URL: https://github.com/apache/incubator-pulsar/pull/1087#discussion_r163719058
 
 

 ##########
 File path: 
pulsar-broker-common/src/main/java/org/apache/pulsar/broker/authentication/AuthenticationService.java
 ##########
 @@ -81,12 +81,15 @@ public String authenticate(AuthenticationDataSource 
authData, String authMethodN
         }
     }
 
-    public String authenticateHttpRequest(HttpServletRequest request) throws 
AuthenticationException {
+    public String authenticateHttpRequest(HttpServletRequest request) throws 
PulsarHttpAuthenticationException {
+        PulsarHttpAuthenticationException exception = new 
PulsarHttpAuthenticationException("Authentication required");
 
 Review comment:
   I made it create `realmInformation` string to avoid creating an exception.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to