rdhabalia closed pull request #1106: Fix: ignore auth flag for websocket-proxy to broker authentication URL: https://github.com/apache/incubator-pulsar/pull/1106
This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/pulsar-websocket/src/main/java/org/apache/pulsar/websocket/WebSocketService.java b/pulsar-websocket/src/main/java/org/apache/pulsar/websocket/WebSocketService.java index 28a0ed511..02a589ff5 100644 --- a/pulsar-websocket/src/main/java/org/apache/pulsar/websocket/WebSocketService.java +++ b/pulsar-websocket/src/main/java/org/apache/pulsar/websocket/WebSocketService.java @@ -184,7 +184,8 @@ private PulsarClient createClientInstance(ClusterData clusterData) throws IOExce clientConf.setIoThreads(config.getWebSocketNumIoThreads()); clientConf.setConnectionsPerBroker(config.getWebSocketConnectionsPerBroker()); - if (config.isAuthenticationEnabled()) { + if (isNotBlank(config.getBrokerClientAuthenticationPlugin()) + && isNotBlank(config.getBrokerClientAuthenticationParameters())) { clientConf.setAuthentication(config.getBrokerClientAuthenticationPlugin(), config.getBrokerClientAuthenticationParameters()); } ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services