saandrews commented on a change in pull request #1168: Proxy roles enforcement
URL: https://github.com/apache/incubator-pulsar/pull/1168#discussion_r165785422
 
 

 ##########
 File path: 
pulsar-proxy/src/test/java/org/apache/pulsar/proxy/server/ProxyRolesEnforcementTest.java
 ##########
 @@ -0,0 +1,266 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.pulsar.proxy.server;
+
+import static org.mockito.Mockito.spy;
+
+import java.io.IOException;
+import java.util.HashMap;
+import java.util.HashSet;
+import java.util.Map;
+import java.util.Map.Entry;
+import java.util.Set;
+
+import javax.naming.AuthenticationException;
+
+import org.apache.bookkeeper.test.PortManager;
+import org.apache.pulsar.broker.ServiceConfiguration;
+import org.apache.pulsar.broker.authentication.AuthenticationDataSource;
+import org.apache.pulsar.broker.authentication.AuthenticationProvider;
+import org.apache.pulsar.client.admin.PulsarAdmin;
+import org.apache.pulsar.client.api.Authentication;
+import org.apache.pulsar.client.api.AuthenticationDataProvider;
+import org.apache.pulsar.client.api.Consumer;
+import org.apache.pulsar.client.api.ConsumerConfiguration;
+import org.apache.pulsar.client.api.ProducerConsumerBase;
+import org.apache.pulsar.client.api.PulsarClient;
+import org.apache.pulsar.client.api.PulsarClientException;
+import org.apache.pulsar.client.api.SubscriptionType;
+import org.apache.pulsar.common.policies.data.AuthAction;
+import org.apache.pulsar.common.policies.data.ClusterData;
+import org.apache.pulsar.common.policies.data.PropertyAdmin;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+import org.testng.Assert;
+import org.testng.annotations.BeforeMethod;
+import org.testng.annotations.Test;
+
+import com.google.common.collect.Lists;
+import com.google.common.collect.Sets;
+
+public class ProxyRolesEnforcementTest extends ProducerConsumerBase {
+    private static final Logger log = 
LoggerFactory.getLogger(ProxyRolesEnforcementTest.class);
+
+    public static class BasicAuthenticationData implements 
AuthenticationDataProvider {
+        private String authParam;
+
+        public BasicAuthenticationData(String authParam) {
+            this.authParam = authParam;
+        }
+        
+        public boolean hasDataFromCommand() {
+            return true;
+        }
+
+        public String getCommandData() {
+            return authParam;
+        }
+        
+        public boolean hasDataForHttp() {
+            return true;
+        }
+        
+        @Override
+        public Set<Entry<String, String>> getHttpHeaders() {
+            Map<String, String> headers = new HashMap<>();
+            headers.put("BasicAuthentication", authParam);
+            return headers.entrySet();
+        }
+    }
+    
+    public static class BasicAuthentication implements Authentication {
+
+        private String authParam;
+
+        @Override
+        public void close() throws IOException {
+            // noop
+        }
+
+        @Override
+        public String getAuthMethodName() {
+            return "BasicAuthentication";
+        }
+
+        @Override
+        public AuthenticationDataProvider getAuthData() throws 
PulsarClientException {
+            try {
+                return new BasicAuthenticationData(authParam);
+            } catch (Exception e) {
+                throw new PulsarClientException(e);
+            }
+        }
+
+        @Override
+        public void configure(Map<String, String> authParams) {
+            this.authParam = authParams.get("authParam");
+        }
+
+        @Override
+        public void start() throws PulsarClientException {
+            // noop
+        }
+    }
+    
+    public static class BasicAuthenticationProvider implements 
AuthenticationProvider {
+
+        @Override
+        public void close() throws IOException {            
+        }
+
+        @Override
+        public void initialize(ServiceConfiguration config) throws IOException 
{            
+        }
+
+        @Override
+        public String getAuthMethodName() {
+            return "BasicAuthentication";
+        }
+
+        @Override
+        public String authenticate(AuthenticationDataSource authData) throws 
AuthenticationException {
+            if (authData.hasDataFromCommand()) {
+                return authData.getCommandData();
+            } else if (authData.hasDataFromHttp()) {
+                return authData.getHttpHeader("BasicAuthentication");
+            }
+            
+            return null;
+        }
+    }
+
+    private int webServicePort;
+    private int servicePort;
+    
+    @BeforeMethod
+    @Override
+    protected void setup() throws Exception {
+        webServicePort = PortManager.nextFreePort();
+        servicePort = PortManager.nextFreePort();
+        // enable tls and auth&auth at broker 
+        conf.setAuthenticationEnabled(true);
+        conf.setAuthorizationEnabled(true);
+        conf.setTlsEnabled(false);
+        
conf.setBrokerClientAuthenticationPlugin(BasicAuthentication.class.getName());
+        conf.setBrokerClientAuthenticationParameters("authParam:broker");
+        
+        Set<String> superUserRoles = new HashSet<String>();
+        superUserRoles.add("admin");
+        conf.setSuperUserRoles(superUserRoles);
+        
+        Set<String> providers = new HashSet<String>();
+        providers.add(BasicAuthenticationProvider.class.getName());
+        conf.setAuthenticationProviders(providers);
+
+        conf.setClusterName("use");
+        Set<String> proxyRoles = new HashSet<String>();
+        proxyRoles.add("proxy");
+        conf.setProxyRoles(proxyRoles);
+
+        super.init();
+    }
+
+    @Override
+    protected void cleanup() throws Exception {
+        super.internalCleanup();       
+    }
+    
+    @Test
+    void testIncorrectRoles() throws Exception {
+        log.info("-- Starting {} test --", methodName);
+
+        // Step 1: Create Admin Client
+        createAdminClient();
+        final String proxyServiceUrl = "pulsar://localhost:" + servicePort;
+        // create a client which connects to proxy over tls and pass authData
 
 Review comment:
   If the test is not using tls, please remove the comment.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to