rdhabalia commented on a change in pull request #1171: Fixed managed ledger 
missing callback issue when unloading a topic
URL: https://github.com/apache/incubator-pulsar/pull/1171#discussion_r165853303
 
 

 ##########
 File path: 
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/Producer.java
 ##########
 @@ -279,8 +280,12 @@ public void completed(Exception exception, long ledgerId, 
long entryId) {
                         ? ServerError.TopicTerminatedError : 
ServerError.PersistenceError;
 
                 producer.cnx.ctx().channel().eventLoop().execute(() -> {
-                    
producer.cnx.ctx().writeAndFlush(Commands.newSendError(producer.producerId, 
sequenceId, serverError,
-                            exception.getMessage()));
+                    if (!(exception instanceof TopicClosedException)) {
 
 Review comment:
   Here, broker may have sent close producer response but what is the downside 
here if we still send a response back? I think in old client, it didn't support 
close-producer command so, in that case shouldn't we send this response back?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to