Licht-T commented on a change in pull request #1182: Remove constexpr from C++
client
URL: https://github.com/apache/incubator-pulsar/pull/1182#discussion_r166156092
##########
File path: pulsar-client-cpp/lib/Murmur3_32Hash.h
##########
@@ -38,9 +38,6 @@ class Murmur3_32Hash : public Hash {
int32_t makeHash(const std::string& key);
private:
- static constexpr int32_t CHUNK_SIZE = 4;
Review comment:
IMO, macro is better solution in C++03.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
