jai1 commented on a change in pull request #1169: Proxy forward auth data
URL: https://github.com/apache/incubator-pulsar/pull/1169#discussion_r166176489
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java
##########
@@ -385,8 +465,11 @@ protected void handleConnect(CommandConnect connect) {
if (sslHandler != null) {
sslSession = ((SslHandler)
sslHandler).engine().getSession();
}
-
- originalPrincipal = connect.hasOriginalPrincipal() ?
connect.getOriginalPrincipal() : null;
+ originalPrincipal = getOriginalPrincipal(
+ connect.hasOriginalAuthData() ?
connect.getOriginalAuthData() : null,
+ connect.hasOriginalAuthMethod() ?
connect.getOriginalAuthMethod() : null,
+ connect.hasOriginalPrincipal() ?
connect.getOriginalPrincipal() : null,
+ sslSession);
Review comment:
is sslSession is null AuthDataCommand.hasDataFromTls will return false
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
